Fix issue #749 #750
Open
Fix issue #749 #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sukhvansh2004 <[email protected]>
Signed-off-by: Sukhvansh2004 <[email protected]>
Signed-off-by: Sukhvansh2004 <[email protected]>
Signed-off-by: Sukhvansh2004 <[email protected]>
|
Hi @clalancette , I noticed you are an active maintainer of this repository. Would you mind reviewing this PR? If everything looks good, it would be great if you could merge it into the repo. Thanks for your time and help! |
tfoote
requested changes
Jan 27, 2025
There was a problem hiding this comment.
Making a core change like this will need to have a test case that we can review for correctness. And then from that we can consider the correctness of the existing implementation and the new proposed one.
How did you validate the indexing shifts?
And why did you remove the time check?
| @@ -1583,25 +1583,24 @@ void BufferCore::_chainAsVector( | |||
| } | |||
| } | |||
|
|
|||
| if (source_time != target_time) { | |||
There was a problem hiding this comment.
Removing this check is clearly wrong. You only traverse the tree a second time if the times are different.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So what I saw in the function implementation was that the indexing in the erase function was not correct and the target chain not pushed correctly back into the source chain, so have fixed that.
Fixes #749